Conversation
| // // this seems to discard failures, for better errors messages we might want to implement a different method (simulateBlock?) | ||
| // val result = blockPreparator.prepareBlock(block) | ||
| // Right(result.blockResult.receipts) | ||
| // FIXME DO WE NEED THAT? |
There was a problem hiding this comment.
Maybe we could create task to delete those snappy tests? (I highly doubt anybody will ever use it)
There was a problem hiding this comment.
Good idea. I just created https://jira.iohk.io/browse/ETCM-349
| @@ -67,7 +67,13 @@ class BlockExecution( | |||
| * @param block the block with transactions to run | |||
| */ | |||
| private[ledger] def executeBlockTransactions(block: Block): Either[BlockExecutionError, BlockResult] = { | |||
There was a problem hiding this comment.
maybe it would be possible to pass parent header here as param , to avoid this blockchain.getBlockHeaderByHash(block.header.parentHash ?
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
Apart from the below comments, LGTM!
Do you think there's any test that could be added for any of the two issues?
|
@ntallar I don't think that we are able to add some reliable test to check that. I can't imagine any |
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
4 participants
Description
stateRootfromOptiontoByteStringinWorldStateProxyto avoid mistakesprepareBlockmethod.This change should also solve the issue described in ETCM-329