Skip to content

[ETCM-202] Fix address derivation command#753

Merged
mmrozek merged 1 commit intodevelopfrom
etcm-202-mantis-cli
Oct 22, 2020
Merged

[ETCM-202] Fix address derivation command#753
mmrozek merged 1 commit intodevelopfrom
etcm-202-mantis-cli

Conversation

@mmrozek
Copy link
Copy Markdown
Contributor

@mmrozek mmrozek commented Oct 22, 2020

Description

Fix address derivation (address length)

@mmrozek mmrozek requested a review from kapke October 22, 2020 07:37
@@ -62,8 +63,9 @@ object CliCommands {

private def privKeyToAddress(privKey: Array[Byte]): String = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be now Address.fromPrivateKey?

Copy link
Copy Markdown
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmrozek mmrozek merged commit 69932a3 into develop Oct 22, 2020
@mmrozek mmrozek deleted the etcm-202-mantis-cli branch October 22, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants