Skip to content

[ETCM-126] single actor system in JsonRPController specs#751

Merged
lemastero merged 3 commits intodevelopfrom
ETCM-126-review-single-ActorSystem
Oct 21, 2020
Merged

[ETCM-126] single actor system in JsonRPController specs#751
lemastero merged 3 commits intodevelopfrom
ETCM-126-review-single-ActorSystem

Conversation

@lemastero
Copy link
Copy Markdown
Contributor

@lemastero lemastero commented Oct 21, 2020

Description

Fix review remark use single ActorSystem in JsonRpcController*Spec and properly close it.

Comment thread src/test/scala/io/iohk/ethereum/jsonrpc/JsonRpcControllerEthSpec.scala Outdated
Comment thread src/test/scala/io/iohk/ethereum/jsonrpc/JsonRpcControllerEthTransactionSpec.scala Outdated
Comment thread src/test/scala/io/iohk/ethereum/jsonrpc/JsonRpcControllerPersonalSpec.scala Outdated
Copy link
Copy Markdown
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lemastero lemastero merged commit 5b0eb05 into develop Oct 21, 2020
@lemastero lemastero deleted the ETCM-126-review-single-ActorSystem branch October 21, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants