Conversation
lemastero
force-pushed
the
ETCM-141-scalafmt
branch
from
bdb5771 to
70c8dc5
Compare
This was referenced Oct 17, 2020
lemastero
requested review from
KonradStaniec,
kapke,
mmrozek,
ntallar and
pslaski
Contributor
|
Should we add |
kapke
reviewed
Oct 19, 2020
| }; | ||
|
|
||
| scalafmt = commonAttrs // { | ||
| dependsOn = [ compile ]; |
Contributor
There was a problem hiding this comment.
Why not other way around? Checking formatting is much more lightweight than compiling.
Contributor
Author
There was a problem hiding this comment.
Nice idea, changed, and now compile depends on formatting.
kapke
approved these changes
Oct 19, 2020
Contributor
kapke
left a comment
kapke
left a comment
There was a problem hiding this comment.
Let's get this merged as soon as CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add scalafmt plugin and format all code.