[Chore] Detailed logging of the handshaked peers#719
Merged
Conversation
mmrozek
reviewed
Oct 5, 2020
| override def toString: String = | ||
| s"PeerNetworkStatus {" + | ||
| s" RemotePeerAddress: ${peer.remoteAddress}," + | ||
| s" ConnectionDirection: ${if (peer.incomingConnection) "Incoming" else "OutGoing"}," + |
| peer, | ||
| isBlacklisted = isBlacklisted(peer.id) | ||
| ) | ||
| log.debug(s"${peer.id} - $peerNetworkStatus") |
Contributor
There was a problem hiding this comment.
I would prefer to put everything in one log msg. It will be easier to debug (when we will have structured logging) to have the whole list in one log entry
added 3 commits
October 6, 2020 12:16
mmrozek
approved these changes
Oct 7, 2020
Contributor
mmrozek
left a comment
mmrozek
left a comment
There was a problem hiding this comment.
Minor comment only. LGTM
| peersToDownloadFrom.size | ||
| ) | ||
|
|
||
| val handshakedPeersStatus = handshakedPeers.map { case (peer, info) => |
Contributor
There was a problem hiding this comment.
Minor: should be lazy to avoid evaluation when we work with INFO level of logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More in detail logging of all the handshaked peers a node is connected to