[Chore] Fix compilation issues with updated web3j#710
Conversation
mmrozek
left a comment
mmrozek
left a comment
There was a problem hiding this comment.
The changes from .circleci/config should be reflected in buildkite config
if you are referring to compile-all step, that is already there: https://github.com/input-output-hk/mantis/pull/707/files#diff-4bc7af90a8380d7ed64283e70a4d7f2dR15 |
mirkoAlic
changed the title
| name: additional compilation & dist | ||
| # this step builds parts of the codebase which are not tested in CI | ||
| # so as to prevent compilation regression | ||
| command: $SBT benchmark:compile snappy:compile dist |
There was a problem hiding this comment.
Maybe we could keep dist step?
There was a problem hiding this comment.
Is already included for buildkite pipeline: https://github.com/input-output-hk/mantis/pull/707/files#diff-4bc7af90a8380d7ed64283e70a4d7f2dR84
or you mean having it as a separate step?
…nto chore-update-web3j Conflicts: - .circleci/config.yml + "org.web3j" % "core" % "5.0.0" TODO: Apply nix-expr.patch from buildkite run!
4 participants
Description
Fix compilation issues with updated web3j,
make Circle compile all targets.