[ETCM-44] Treasury block reward distribution#694
Merged
Conversation
38cbba7 to
ea15d31
Compare
ea15d31 to
787810f
Compare
mirkoAlic
reviewed
Sep 28, 2020
| val syncConfig = SyncConfig(Config.config) | ||
| class BlockRewardSpec extends AnyFlatSpec with Matchers with ScalaCheckPropertyChecks with MockFactory { | ||
|
|
||
| "Reward Calculation" should "pay to the miner if no ommers included" in new TestSetup { |
…for implicit BlockRewardCalculatorWithFullReward
| @@ -45,26 +46,47 @@ class BlockPreparator( | |||
| * @return | |||
| */ | |||
| private[ledger] def payBlockReward(block: Block, worldStateProxy: InMemoryWorldStateProxy): InMemoryWorldStateProxy = { | |||
Contributor
There was a problem hiding this comment.
Just minor comment: I would update scaladoc, to reflect all the changes and maybe mention treasury spec.
Author
There was a problem hiding this comment.
Just did! I'm not sure whether to mention the spec or not as it's not public yet. I think the description I added should be a good enough description without having to refer to it
KonradStaniec
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapts block reward distribution to the treasury
Proposed Solution
Follows the specification described in this section:
Testing
Testing on mainnet
Testing on private network
Pending