Skip to content

[CHORE] Refactor dependencies, update scalacheck#676

Merged
mirkoAlic merged 14 commits intodevelopfrom
refactor-dependencies
Sep 18, 2020
Merged

[CHORE] Refactor dependencies, update scalacheck#676
mirkoAlic merged 14 commits intodevelopfrom
refactor-dependencies

Conversation

@mmrozek
Copy link
Copy Markdown
Contributor

@mmrozek mmrozek commented Sep 16, 2020

Description

  • Move dependencies to separate file
  • update scalacheck

CAUTION: a majority of changes is caused by renaming of PropertyChecks trait and formatting all touched files. Please don't be afraid ;)

@mmrozek mmrozek force-pushed the refactor-dependencies branch from f79f14c to bfc624b Compare September 17, 2020 06:47
Comment thread repo.nix Outdated
"nix-rocksDb" = "";
};
"artifacts" = {
"nix-local-preloaded/file:/Users/mmrozek/.sbtix/preloaded/com/trueaccord/lenses/lenses_2.12/0.4.12/lenses_2.12-0.4.12.jar" = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=/

@mirkoAlic
Copy link
Copy Markdown
Contributor

mirkoAlic commented Sep 17, 2020

Fix nix build is still needed, but apart from that, LGTM!

@mirkoAlic mirkoAlic added the update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code label Sep 17, 2020
Comment thread .scalafmt.conf
Copy link
Copy Markdown
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing and look good to me!

Comment thread build.sbt Outdated
val circeVersion = "0.9.3"
val rocksDb = "6.11.4"
// Resolver for rocksDb
resolvers += "rocksDb" at "https://dl.bintray.com/ethereum/maven/"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove it now, see 56e9336

# is pulled from the corresponding consensus implementation.
# For example, in case of ethash, a section named `ethash` is used.
# Available protocols: ethash, mocked
# In case of mocked, remember to enable qa api
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mirkoAlic mirkoAlic merged commit 68dfe36 into develop Sep 18, 2020
@mirkoAlic mirkoAlic deleted the refactor-dependencies branch September 18, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants