Skip to content

[ECTM-80] QA Service + mocked miner#670

Merged
mirkoAlic merged 4 commits intodevelopfrom
ectm-80-qa-service
Sep 16, 2020
Merged

[ECTM-80] QA Service + mocked miner#670
mirkoAlic merged 4 commits intodevelopfrom
ectm-80-qa-service

Conversation

@mmrozek
Copy link
Copy Markdown
Contributor

@mmrozek mmrozek commented Sep 15, 2020

Description

  • mocked miner implementation
  • QA service (mining blocks using mocked miner, listing pending txs)

Comment thread .scalafmt.conf
@@ -0,0 +1,3 @@
version = "2.3.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7.1 is the latest :)

Comment thread build.sbt
"org.bouncycastle" % "bcprov-jdk15on" % "1.59",
"com.typesafe.scala-logging" %% "scala-logging" % "3.9.0",
"org.typelevel" %% "mouse" % "0.18",
"org.typelevel" %% "mouse" % "0.23",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could start adding new Dependencies following the approach we use in the other project. (like i started doing it here: https://github.com/input-output-hk/mantis/pull/668/files#diff-fdc3abdfd754eeb24090dbd90aeec2ceR77) WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should do that. I will do that in separate PR

import io.iohk.ethereum.utils.ByteStringUtils
import scala.concurrent.duration._

class MockedMiner(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import scala.concurrent.ExecutionContext
import scala.language.higherKinds

trait SpecBase extends TypeCheckedTripleEquals with DiagrammedAssertions with Matchers { self: AsyncTestSuite =>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@mirkoAlic
Copy link
Copy Markdown
Contributor

Please update insomnia workspace (Yes we already have one =) )

Copy link
Copy Markdown
Contributor

@mirkoAlic mirkoAlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirkoAlic mirkoAlic merged commit 63283cc into develop Sep 16, 2020
@mirkoAlic mirkoAlic deleted the ectm-80-qa-service branch September 16, 2020 11:46
Comment thread .scalafmt.conf
@@ -0,0 +1,3 @@
version = "2.3.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7.1 is the latest :)

Comment thread build.sbt
"com.typesafe.scala-logging" %% "scala-logging" % "3.9.0",
"org.typelevel" %% "mouse" % "0.18",
"org.typelevel" %% "mouse" % "0.23",
"org.typelevel" %% "cats-core" % "2.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure all of them can be bumped up a bit. IIRC Cats - 2.2, Monix 3.2, etc.

# Available choices are: eth, web3, net, personal, test, daedalus, iele
apis = "eth,web3,net,personal,daedalus,debug"
# Available choices are: eth, web3, net, personal, test, daedalus, iele, qa
apis = "eth,web3,net,personal,daedalus,debug,qa"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't section about available consensus/pow algorithms be updated as well?
shouldn't config in universal be updated for sake of documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants