Conversation
mmrozek
requested review from
KonradStaniec,
kaii-zen,
mirkoAlic and
ntallar
kaii-zen
approved these changes
Sep 11, 2020
Contributor
kaii-zen
left a comment
kaii-zen
left a comment
There was a problem hiding this comment.
I cherry-picked the commit on top of chore/update-sbt-add-nix and it seems to make my problems go away so 
plz
mirkoAlic
reviewed
Sep 11, 2020
| } | ||
|
|
||
| consensus { | ||
| coinbase = "0011223344556677889900112233445566778899" # has to be changed for each node |
Contributor
There was a problem hiding this comment.
why this is part of the default?
Contributor
Author
There was a problem hiding this comment.
I wanted to have anything here(it is the default from application.conf). For each node, we have to obtain a different account
KonradStaniec
approved these changes
Sep 11, 2020
Contributor
KonradStaniec
left a comment
KonradStaniec
left a comment
There was a problem hiding this comment.
Small comment to double check, also you need to sign your commit :)
| dao = null | ||
| bootstrap-nodes = [] | ||
| include "base.conf" | ||
| frontier-block-number = "0" |
Contributor
There was a problem hiding this comment.
I would double check if we do not have some boolean conflicts when are block numbers are equal to 0 (like in ets test sometimes we have fork block equal to -1 to keep the ordering between forks)
mmrozek
force-pushed
the
private-testnet-config
branch
from
4c0cc3d to
22c5051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial config for the private testnet: