[Chore] Add nix build by mirkoAlic · Pull Request #661 · input-output-hk/mantis

mirkoAlic · 2020-09-09T11:54:30Z

Description

This enables building Mantis in a sandbox.

Proposed Solution

Use Sbtix to generate Nix expressions from
sbt configs. The generated Nix expressions are functionally equivalent to the
(already removed) verify.sbt file and must be updated on the same
occasions that verify.sbt would (i.e., whenever dependencies are updated or changed).

Testing

to generate nix expressions:

nix-shell -p nixUnstable
sbtix-gen-all2

to build:

nix-build

to run:

result/bin/mantis -Dconfig.file=src/main/resources/application.conf

mirkoAlic · 2020-09-11T11:59:51Z

@@ -0,0 +1,26 @@
+# this file must still be generated manually.  


why we need both: ./manual-repo.nix, project/manual-repo.nix? also.. project/project/manual-repo.nix ???

mirkoAlic · 2020-09-11T12:01:04Z

@@ -0,0 +1,51 @@
+# this file originates from SBTix


can we improve the comment, i mean, this file is originates from SBTix but as far as i know we also added some stuff.

mirkoAlic · 2020-09-11T12:02:58Z

@@ -0,0 +1,1872 @@
+# This file was automatically generated by Sbtix. Do not edit manually.


if this is automatically generated, why we need to push it to the repo?

mirkoAlic · 2020-09-11T12:04:38Z

@@ -1,5 +0,0 @@
-#!/bin/bash
-
-DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"


we discovered why this was causing troubles?

kaii-zen · 2020-09-15T11:05:31Z

Added Hydra builds. Can we merge this already so that other PRs get hydra builds as well?

mirkoAlic · 2020-09-15T11:35:32Z

Added Hydra builds. Can we merge this already so that other PRs get hydra builds as well?

In order to get this merge you should:

Solve conflicts in build.sbt (Probably a re-fresh of the repo.nix files is needed).
^ I didn't do it, because i'm still struggling nix issues that i don't understand...So is up to you guys.
I asked/raise some concerns in the comments, is not a blocker for get this PR merged, but if you could respond them, it would be nice.

- Update Sbt - Update Scala - Remove sbt-verify package: In the near future will covered by nix build

mirkoAlic · 2020-09-16T11:16:27Z

@@ -1 +1 @@
-sbt.version = 1.3.13
+sbt.version = 1.2.8


why? i mean, it was necessary?

Me and @sevanspowell were pulling our hair on this all night... briefly, given that:

Sbtix doesn't work correctly with SBT 1.3 (it creates a repo.nix that references local path)

We don't really know how to fix Sbtix for SBT 1.3

We don't know how to estimate how long it would take to figure it out

We have some aggressive time constraints

SBT 1.3 is at best a nice-to-have (this is an assumption, correct me if I'm wrong)

Other urgent tasks are blocked by this not being merged

therefore we made an executive decision to go back to 1.2.8 which was already known to work...

first of all thanks for the clarification and all the effort you are doing! Yeah, fully agree, it was not a requirement. We can get rid off it, given are current deadlines. (On devops-sync call we also agreed upon that)

mirkoAlic · 2020-09-16T15:53:54Z

This needs a dependencies regeneration again. And i can't do in it (still not working in my machine), so please someone try to.

kaii-zen · 2020-09-16T19:08:06Z

I regenerated and now it fails to build.

mirkoAlic · 2020-09-16T19:37:44Z

    "nix-public" = "";
  };
  "artifacts" = {
+    "nix-local-preloaded/file:/Users/kreisys/.sbtix/preloaded/com/eed3si9n/shaded-scalajson_2.12/1.0.0-M4/shaded-scalajson_2.12-1.0.0-M4.jar" = {


karma, is that you?

disassembler force-pushed the chore/update-sbt-add-nix branch 3 times, most recently from 5070562 to 3ef9ce2 Compare September 9, 2020 13:45

mirkoAlic force-pushed the chore/update-sbt-add-nix branch from 3ef9ce2 to d0c9796 Compare September 9, 2020 15:59

disassembler force-pushed the chore/update-sbt-add-nix branch 2 times, most recently from 84b22cf to 0ebe794 Compare September 10, 2020 11:27

mirkoAlic commented Sep 11, 2020

View reviewed changes

mirkoAlic force-pushed the chore/update-sbt branch from e1c81f2 to 8e97c4e Compare September 11, 2020 12:20

mirkoAlic commented Sep 11, 2020

View reviewed changes

Comment thread shell.nix

manveru force-pushed the chore/update-sbt-add-nix branch from 1b65c10 to 821e35a Compare September 14, 2020 08:09

Base automatically changed from chore/update-sbt to develop September 14, 2020 12:57

kaii-zen force-pushed the chore/update-sbt-add-nix branch from 308e09f to 6f353af Compare September 15, 2020 10:37

mirkoAlic marked this pull request as ready for review September 15, 2020 11:36

mirkoAlic and others added 5 commits September 16, 2020 15:10

[Chore] Project build updates

de004ca

- Update Sbt - Update Scala - Remove sbt-verify package: In the near future will covered by nix build

initial nix build

8bd4f29

update dependencies

792bef1

Add release.nix

bb9d9dd

Fix build

a597ef0

kaii-zen force-pushed the chore/update-sbt-add-nix branch from 6f353af to a597ef0 Compare September 16, 2020 08:41

mirkoAlic commented Sep 16, 2020

View reviewed changes

Merge resolved

cc285de

Regen nix deps

f00cade

mirkoAlic commented Sep 16, 2020

View reviewed changes

Regen nix deps pt 2

dfdab1e

mirkoAlic merged commit ed10b5d into develop Sep 17, 2020

mirkoAlic deleted the chore/update-sbt-add-nix branch September 17, 2020 11:14

mirkoAlic changed the title ~~[Chore] Add nix~~ [Chore] Add nix build Sep 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Chore] Add nix build#661

[Chore] Add nix build#661
mirkoAlic merged 8 commits intodevelopfrom
chore/update-sbt-add-nix

mirkoAlic commented Sep 9, 2020 •

edited

Loading

Uh oh!

mirkoAlic Sep 11, 2020 •

edited

Loading

Uh oh!

mirkoAlic Sep 11, 2020

Uh oh!

mirkoAlic Sep 11, 2020

Uh oh!

mirkoAlic Sep 11, 2020

Uh oh!

Uh oh!

kaii-zen commented Sep 15, 2020 •

edited

Loading

Uh oh!

mirkoAlic commented Sep 15, 2020

Uh oh!

mirkoAlic Sep 16, 2020

Uh oh!

kaii-zen Sep 16, 2020

Uh oh!

mirkoAlic Sep 16, 2020

Uh oh!

mirkoAlic commented Sep 16, 2020

Uh oh!

kaii-zen commented Sep 16, 2020

Uh oh!

mirkoAlic Sep 16, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,26 @@
		# this file must still be generated manually.

		@@ -0,0 +1,1872 @@
		# This file was automatically generated by Sbtix. Do not edit manually.

		@@ -1,5 +0,0 @@
		#!/bin/bash

		DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

		@@ -1 +1 @@
		sbt.version = 1.3.13
		sbt.version = 1.2.8

Conversation

mirkoAlic commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Proposed Solution

Testing

Uh oh!

mirkoAlic Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mirkoAlic Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

mirkoAlic Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

mirkoAlic Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaii-zen commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mirkoAlic commented Sep 15, 2020

Uh oh!

mirkoAlic Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

kaii-zen Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

mirkoAlic Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

mirkoAlic commented Sep 16, 2020

Uh oh!

kaii-zen commented Sep 16, 2020

Uh oh!

mirkoAlic Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mirkoAlic commented Sep 9, 2020 •

edited

Loading

mirkoAlic Sep 11, 2020 •

edited

Loading

kaii-zen commented Sep 15, 2020 •

edited

Loading

mirkoAlic Sep 16, 2020 •

edited

Loading