[ETCM-980] encode empty "to" address in transaction RPC reply#1057
Merged
[ETCM-980] encode empty "to" address in transaction RPC reply#1057
Conversation
Contributor
|
Interesting, I actually did the same change way back but it was reverted quickly after: I wonder if you'll run into anything. Does retesteth not complain about extra fields? |
jvdp
approved these changes
Jul 12, 2021
AnastasiiaL
approved these changes
Jul 12, 2021
Contributor
Author
|
Actually, unit-tests are not happy with this change. |
strauss-m
force-pushed
the
fix/ETCM-980_unmarshal_error
branch
8 times, most recently
from
ce7590f to
29a0349
Compare
strauss-m
force-pushed
the
fix/ETCM-980_unmarshal_error
branch
from
29a0349 to
58931bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transaction's field "to" was not encoded in contract creation since it was not set.
The facilitate ETS success, this field is expected to always be present.
Proposed Solution
The fix allows the encoding of empty fields, and remove the duplicated (and not working) custom option serializer