[ETCM-921] Add optional access lists to transactions#1040
Merged
dzajkowski merged 6 commits intodevelopfrom Jul 8, 2021
Merged
[ETCM-921] Add optional access lists to transactions#1040dzajkowski merged 6 commits intodevelopfrom
dzajkowski merged 6 commits intodevelopfrom
Conversation
dzajkowski
force-pushed
the
feature/etcm-921-optional-access-list-3
branch
from
e7d3aaf to
42ac0e0
Compare
AurelienRichez
approved these changes
Jul 7, 2021
lukasz-golebiewski
approved these changes
Jul 7, 2021
| } | ||
| } | ||
|
|
||
| case class TransactionWithAccessList( |
Contributor
There was a problem hiding this comment.
Could this by any chance simply be a Transaction? :-)
Contributor
Author
There was a problem hiding this comment.
it would collide with trait Transaction. or do you have a good name for the base one?
Contributor
There was a problem hiding this comment.
TransactionBase maybe?
Contributor
Author
There was a problem hiding this comment.
the deal with typed transactions is that there will be more of them. this one is just the first. I could name it TypedTransaction01.
02 has already been proposed and is being adapted afaik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR to allow bodies to contain TypedTransactions and LegacyTransactions at the same time (Magneto HF).
It renames the base transaction type, introduces the TransactionWithAccessList class and fixes unit tests.
More to come.