Merged
Conversation
added 8 commits
July 6, 2021 14:54
added 10 commits
July 7, 2021 17:08
…lidatorsExecutor, BlockGenerator, BlockValidation, BlockPreparator, ...)
…uncake-blockchain-config
jvdp
force-pushed
the
refactor/ETCM-966-uncake-blockchain-config
branch
from
6214093 to
6586c4d
Compare
strauss-m
reviewed
Jul 8, 2021
strauss-m
reviewed
Jul 8, 2021
added 2 commits
July 8, 2021 14:55
…uncake-blockchain-config
AurelienRichez
approved these changes
Jul 16, 2021
strauss-m
approved these changes
Jul 16, 2021
…uncake-blockchain-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This to fix some issues with test mode where (parts of) BlockchainConfig can change at run time, and also try out a refactoring to deal with issues stemming from the cake pattern:
BlockchainConfigBuildertrait in this case) instead of theBlockchainConfigdirectly. This preserves the laziness in build initialization order (as provided by the cake) and configurability for tests. And also adds mutability, which is convenient for test mode.BlockchainConfigdependency as a parameter but get it as implicit parameter instead. By using the implicit, impact on code is minimized and this refactoring is entirely mechanical in only a few places (the builder trait, the service class itself and test setup.)