[ETCM-939] refactor Ledger (by removing it)#1026
Merged
Conversation
added 19 commits
June 18, 2021 15:40
lukasz-golebiewski
approved these changes
Jun 24, 2021
Contributor
lukasz-golebiewski
left a comment
lukasz-golebiewski
left a comment
There was a problem hiding this comment.
Looks good overall, aside from some commented out code that could be removed
Contributor
|
A description of what you did with the stuff that was in the Ledger would be nice |
AurelienRichez
approved these changes
Jun 28, 2021
AnastasiiaL
reviewed
Jun 28, 2021
Contributor
AnastasiiaL
left a comment
AnastasiiaL
left a comment
There was a problem hiding this comment.
nice to see tests simplified 👍
added 2 commits
June 28, 2021 12:13
Contributor
Author
Basically it was a layer that didn't add much except for complexity. I looked at the dependents and made the following changes:
The types aliases and case classes were moved to a package object and their own files respectively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a journey; it looks easy enough on the
src/mainside but lots of stuff insrc/testunfortunately broke along the way. The commits mostly tell a story of getting more tests passing while moving stuff out ofLedgergradually.