fix(gui): Port Deskflow Qt 6.9 fix - #2231
Conversation
|
@p12tic This PR should make it in for 3.3.0. It is critical. |
bb6f739 to
08dd837
Compare
|
@p12tic I took this fix from Deskflow, but the Have you got any other thoughts on how to approach this w/o bumping C++ std on Windows? |
08dd837 to
e225613
Compare
As raised in #2221, this fix ports the commit from Deskflow that fixes compilation on machines with Qt versions greater than or equal to 6.9. See: deskflow/deskflow#8447 Fixes: #2221.
|
Why not just cast it to The relevant section, if I understand it correctly:
I applied this patch to the source and it builds with Qt 6.9.0. |
|
don't use uint use uint16_t so the size is ensured. (uint should be 2bytes but not on all platforms) |
Based off these comments on #2231. - #2231 (comment) - #2231 (comment)
Based off these comments on #2231. - #2231 (comment) - #2231 (comment) And this patch: https://gist.github.com/sid-code/9131300ee943af1ce5958ee40e527b93 Closes: #2231. Closes: #2221.
|
Closing in favor of #2232. |
Pull request was closed
Based off these comments on #2231. - #2231 (comment) - #2231 (comment) And this patch: https://gist.github.com/sid-code/9131300ee943af1ce5958ee40e527b93 Closes: #2231. Closes: #2221.
Based off these comments on #2231. - #2231 (comment) - #2231 (comment) And this patch: https://gist.github.com/sid-code/9131300ee943af1ce5958ee40e527b93 Closes: #2231. Closes: #2221.
As raised in #2221, this fix ports the commit from Deskflow that fixes compilation on machines with Qt versions greater than or equal to 6.9.
See: deskflow/deskflow#8447
Fixes: #2221.
Contributor Checklist:
doc/newsfragmentsdirectory (and made sure to read theREADME.mdin that directory)