Skip to content

Comments

Return to building on 20.04 and 22.04#186

Merged
ericcurtin merged 1 commit intomasterfrom
manual-bumps
Jul 21, 2023
Merged

Return to building on 20.04 and 22.04#186
ericcurtin merged 1 commit intomasterfrom
manual-bumps

Conversation

@ericcurtin
Copy link
Member

@ericcurtin ericcurtin commented Jul 21, 2023 •
edited
Loading

Building on latest can be unstable, back to manual bumps and availing
of newer OS's via containers. We will likely bump to 24.04 and
drop 20.04 when it's released. Some env var fixes also.

@ericcurtin
Copy link
Member Author

ericcurtin commented Jul 21, 2023

@jankratochvil I'm hoping to change back to this, if you look at the master branch it's failing. It's just more stable when we use LTS hosts and you lose control when you use latest as the version can be bumped automatically at anytime.

It's just hard to keep green builds when using latest.

@jankratochvil
Copy link
Contributor

jankratochvil commented Jul 21, 2023

I did not know there is any difference of latest vs. 22.04. Sure I am fine returning it from latest to 22.04 when it matters.
But could you please keep the other changes?

  • the test should be called build_and_test_multi and not build_and_test. It is executing build_and_test_multi.sh. It is not executing ``build_and_test.sh`.
  • The job should be called ubuntu-something and not build-something when the run is on Ubuntu OS.

@ericcurtin
Copy link
Member Author

ericcurtin commented Jul 21, 2023

build_and_test to build_and_test_multi it is!

and

build-something to ubuntu-something it is!

@jankratochvil
Copy link
Contributor

jankratochvil commented Jul 21, 2023

Is that "gcc scan-build" removal intentional?
Otherwise the change LGTM, thanks.

@ericcurtin
Copy link
Member Author

ericcurtin commented Jul 21, 2023

Is that "gcc scan-build" removal intentional? Otherwise the change LGTM, thanks.

It might be, playing around with that, our build seems to timeout and get stuck/break there, if that's buggy I'll remove it, we would still have the clang version of "scan-build" so I'd be happy to remove it if it was buggy.

@ericcurtin
Return to building on 20.04 and 22.04
a0fc24c 
Building on latest can be unstable, back to manual bumps and availing
of newer OS's via containers. We will likely bump to 24.04 and
drop 20.04 when it's released. Some env var fixes also.
@ericcurtin
Copy link
Member Author

ericcurtin commented Jul 21, 2023

I'm not sure but it might have been the "unset" that fixed this in the end, anyway, green build!

@ericcurtin ericcurtin merged commit eab25a7 into master Jul 21, 2023
@ericcurtin ericcurtin deleted the manual-bumps branch July 21, 2023 11:47
@chenrui333 chenrui333 mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericcurtin @jankratochvil