Fix fanotify_supported()#185
Merged
ericcurtin merged 1 commit intoinotify-tools:masterfrom Jul 16, 2023
Merged
Conversation
Parse negative value of --timeout argument and error only after setting up all watches. this is used to improve the helper to detect support for fanotify on a specific filesystem (e.g. overlayfs) and test permission for specific flags (e.g. --filesystem). With this improvement, we can remove the workaround for not testing fanotify inside containers, because the helper will detect if kernel supports fanotify support inside containers or not (overlayfs support for fanotify should be supported in future kernels). Signed-off-by: Amir Goldstein <[email protected]>
Contributor
Author
|
@ericcurtin not sure why ubuntu-latest-multi failed (internal libpod error) does not seem to be related to my change? |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
|
@ericcurtin since we had the unfortunate of never enabling fanotify by default, I'd like to request that the first release that does support --fanotify will also include this negative-timeout-as-kernel-support-test feature. This will allow me to use the distro shipped fsnotifywait for writing more advances fanotify tests in other test suites (e.g. fstests) where it is easier to test fanotify inside unprivileged userns, with idmapped mounts, etc, when the distro shipped fsnotifywait supports --fanotify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse negative value of --timeout argument and error only after setting up all watches.
this is used to improve the helper to detect support for fanotify on a specific filesystem (e.g. overlayfs) and test permission for specific flags (e.g. --filesystem).
With this improvement, we can remove the workaround for not testing fanotify inside containers, because the helper will detect if kernel supports fanotify support inside containers or not (overlayfs support for fanotify should be supported in future kernels).