Add outerHTML option to serializer. Resolves #230.#347
Closed
internettrans wants to merge 1 commit intoinikulin:masterfrom
Closed
Add outerHTML option to serializer. Resolves #230.#347internettrans wants to merge 1 commit intoinikulin:masterfrom
internettrans wants to merge 1 commit intoinikulin:masterfrom
Conversation
Collaborator
|
Hi @joeldenning, thanks for this PR, agreed that this is a needed feature. I don't think an option is the way to go here; I would opt for a separate method instead. Closing this PR for now. We will continue having #230 as a reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #230. I didn't add tests yet to this because I wasn't sure the best place to do so and also wasn't sure if this change would be welcomed/accepted. I'm happy to add tests after it's reviewed if things are looking good!