Skip to content

ES5 Upgrades for better compilation to ES2020#308

Closed
frank-dspeed wants to merge 1 commit intoinikulin:masterfrom
frank-dspeed:master
Closed

ES5 Upgrades for better compilation to ES2020#308
frank-dspeed wants to merge 1 commit intoinikulin:masterfrom
frank-dspeed:master

Conversation

@frank-dspeed
Copy link
Copy Markdown

No description provided.

@frank-dspeed
Copy link
Copy Markdown
Author

ah anyway forget it i fork of and rename complet i look what methods i can keep and recode the rest as its only a html parser i will get it done on this weekend.

@inikulin
Copy link
Copy Markdown
Owner

Hi, I'm reading through changes and a bit confused. I've expected it to be changes to .mjs syntax, but it doesn't seem to be a case. Also, requirement to transpile it for older versions of node concerns me. Can you provide more details about the motivation for this change, please?

@frank-dspeed
Copy link
Copy Markdown
Author

I want that it is more easy to maintain and deploy reuse in bundlers. we can export a CJS version i don't care but the main code should be ESNext. so that i can use it in node 13 high performant and easy to bundle as dependency also i want to be able to do composition more easy.

@frank-dspeed
Copy link
Copy Markdown
Author

the current changes are only a little part to make it more easy convert able but i will rewrite it complet.

@inikulin
Copy link
Copy Markdown
Owner

As far as I am aware all bundlers support CJS. By "high performance" you mean tree shaking capabilities of some bundlers? I expect that in Node there will be no difference in performance between module and CJS version, or I'm missing something?

@frank-dspeed
Copy link
Copy Markdown
Author

@inkulin your right we can close this i have already complet forked from this. i will look what i keep and what i join into my simple dom implamentation i have now 3 parsers i will benchmark then.

if you want to see the new Next gerneration version where the code is read and useable by 3th you can watch it under @as-esm/parse5 where i need to put anyway more then enought old school modules so that they can get used again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants