Move @types/node to devDependency#202
Closed
ngocvantran wants to merge 1 commit intoinikulin:masterfrom
ngocvantran:patch-1
Closed
Move @types/node to devDependency#202ngocvantran wants to merge 1 commit intoinikulin:masterfrom ngocvantran:patch-1
ngocvantran wants to merge 1 commit intoinikulin:masterfrom
ngocvantran:patch-1
Conversation
Please make @types/node an development dependency so that it won't be installed when parse5 is used.
Owner
|
Why should we do this? |
Author
|
|
Owner
It is used in production code in |
Author
|
You're correct, I did not think about since our project does not use parse5 directly. I'll close the pull request. |
17 tasks
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make @types/node an development dependency so that it won't be installed when parse5 is used.