Skip to content

Use fully qualified std::#73

Merged
stephanecollot merged 1 commit intoing-bank:masterfrom
shadchin:patch-1
Aug 15, 2022
Merged

Use fully qualified std::#73
stephanecollot merged 1 commit intoing-bank:masterfrom
shadchin:patch-1

Conversation

@shadchin
Copy link
Copy Markdown
Contributor

@shadchin shadchin commented Aug 6, 2022 •
edited
Loading

This fixes a compilation error in a really arcane environment I use. Anyway, std should be there.

@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Aug 14, 2022

It seems that the fall in tests is not related to PR

@stephanecollot
Copy link
Copy Markdown
Collaborator

stephanecollot commented Aug 15, 2022

Yes it seems there are some different ordering of the results:

E           assert [[(358, 6.525...345856)], ...] == [[(358, 6.525...345856)], ...]
E             At index 202 diff: [(222, 5.1337743), (113, 5.1337743), (209, 4.973848)] != [(113, 5.1337743), (222, 5.1337743), (209, 4.973848)]
[...]
tests\sparse_dot_topn\test_awesome_cossim_topn.py:278: AssertionError
=========================== short test summary info ===========================
FAILED tests/sparse_dot_topn/test_awesome_cossim_topn.py::test_awesome_cossim_top_small_matrix[0-float32]

I'm clicking retry to see if it is random.

@stephanecollot
Copy link
Copy Markdown
Collaborator

stephanecollot commented Aug 15, 2022

Yes it was random. I merge.

@stephanecollot stephanecollot merged commit 836afad into ing-bank:master Aug 15, 2022
@shadchin shadchin deleted the patch-1 branch August 17, 2022 06:50
@stephanecollot
Copy link
Copy Markdown
Collaborator

stephanecollot commented Feb 13, 2023

FYI it is released in 0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shadchin @stephanecollot