Suppress OpenMP error on double OpenMP initialisation#118
Merged
RUrlus merged 2 commits intoing-bank:masterfrom Sep 3, 2024
Merged
Suppress OpenMP error on double OpenMP initialisation#118RUrlus merged 2 commits intoing-bank:masterfrom
RUrlus merged 2 commits intoing-bank:masterfrom
Conversation
mbaak
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the same strategy as used by scikit-learn to suppress the error (segfault) when OpenMP get loaded twice. This can happen when two or more packages vendor their own OpenMP library like we do.
Scikit-learn maintainers mentioned that they didn't face any issues
Current usage of both this library with Torch triggers a segfault