Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs.prometheus_client): Allow adding custom headers #16566

Merged
merged 1 commit into from
Mar 3, 2025
Merged

feat(outputs.prometheus_client): Allow adding custom headers #16566

merged 1 commit into from
Mar 3, 2025

Conversation

smuth4
Copy link
Contributor

@smuth4 smuth4 commented Feb 27, 2025

Summary

Allow simple setting of custom headers in prometheus_client's HTTP response, in this case to meet security requirements, but also just as a generally useful feature.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16565

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Feb 27, 2025
@smuth4 smuth4 force-pushed the feature/prom-client-headers branch 4 times, most recently from 1dec251 to b40e8b8 Compare February 27, 2025 20:24
@smuth4 smuth4 force-pushed the feature/prom-client-headers branch from b40e8b8 to ff42b7f Compare February 27, 2025 20:33
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @smuth4 for your contribution!

@srebhan srebhan added area/prometheus ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 28, 2025
@mstrandboge mstrandboge merged commit 6d528f2 into influxdata:master Mar 3, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.34.0 milestone Mar 3, 2025
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Mar 10, 2025
@smuth4 @asaharn
feat(outputs.prometheus_client): Allow adding custom headers (influxd…
7b35c7c 
…ata#16566)

Co-authored-by: Stephen Muth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.

Allow custom headers for outputs.prometheus_client
3 participants
@smuth4 @srebhan @mstrandboge