Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.opensearch): Use correct pipeline name while creating bulk-indexers #16555

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix(outputs.opensearch): Use correct pipeline name while creating bulk-indexers #16555

merged 2 commits into from
Mar 4, 2025

Conversation

babasaikiran
Copy link
Contributor

Summary

We are performing an incorrect check when verifying the existence of an opensearchutil.BulkIndexer, leading to the creation of multiple instances. This excessive instantiation results in a memory leak.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16295

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Feb 25, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@babasaikiran
Copy link
Contributor Author

@srebhan can you please look into this PR ?

srebhan
srebhan approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @babasaikiran! Let's ask in the issue to verify this fixes the issue!

@srebhan srebhan changed the title fix(outputs.opensearch): to use correct pipeline name while creating BulkIndexers fix(outputs.opensearch): Use correct pipeline name while creating bulk-indexers Feb 27, 2025
@srebhan srebhan self-assigned this Feb 27, 2025
@srebhan srebhan mentioned this pull request Feb 27, 2025
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 4, 2025
@srebhan srebhan assigned mstrandboge and unassigned srebhan Mar 4, 2025
@mstrandboge mstrandboge merged commit d8548d1 into influxdata:master Mar 4, 2025
28 of 29 checks passed
@github-actions github-actions bot added this to the v1.34.0 milestone Mar 4, 2025
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Mar 10, 2025
@babasaikiran @asaharn
fix(outputs.opensearch): Use correct pipeline name while creating bul…
6dae4e1 
…k-indexers (influxdata#16555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.

Memory Leak (outputs.opensearch with 'use_pipeline')
3 participants
@babasaikiran @srebhan @mstrandboge