Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.modbus): Allow grouping across register types #16040

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat(inputs.modbus): Allow grouping across register types #16040

merged 1 commit into from
Oct 24, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 18, 2024

Summary

Currently, each output of a request has the register-type added as a tag, this prevents grouping across register types. However such a grouping across register types might be helpful especially for the metric configuration-style.

This PR adds a exclude_register_type_tag option which is false by default to keep the current behavior. However, for the request and metric configuration-style this allows to group request outputs across register-types by setting it to true.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16031

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 18, 2024
@srebhan srebhan mentioned this pull request Oct 18, 2024
Closed
@srebhan srebhan self-assigned this Oct 18, 2024
@srebhan srebhan force-pushed the modbus_issue_16031 branch from 2c95f0b to f677e62 Compare October 18, 2024 10:02
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 24, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Oct 24, 2024
mstrandboge
mstrandboge approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@mstrandboge mstrandboge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mstrandboge mstrandboge merged commit f061114 into influxdata:master Oct 24, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 24, 2024
diorcety pushed a commit to diorcety/telegraf that referenced this pull request Mar 6, 2025
@srebhan
feat(inputs.modbus): Allow grouping across register types (influxdata…
649e1ad 
…#16040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.

[inputs.modbus] Group coil/discrete/holding/input metric together
2 participants
@srebhan @mstrandboge