Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regular expression support for dynatrace output counter metrics #15659

Closed
dhruvthak opened this issue Jul 24, 2024 · 3 comments · Fixed by #15668
Closed

add regular expression support for dynatrace output counter metrics #15659

dhruvthak opened this issue Jul 24, 2024 · 3 comments · Fixed by #15668
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue

Comments

@dhruvthak
Copy link
Contributor

Use Case

Metrics:

simple_abc_metric
simple_def_metric

In Dynatrace configuration, we pass /simple_[a-z]+_metric/ to AddCounterMetrics

Expected behavior

The expectation was a regular expression match support

Actual behavior

Instead counter names were string compared

Additional info

Code reference: dynatrace.go#L233

Proposed change:
If the passed value is a regular expression match i.e., starts and ends with a / a regular expression match to be performed else a literal string match to ensure the existing behavior is not affected.

Looking to open a pull request for this change.
@dhruvthak dhruvthak added the feature request Requests for new plugin and for new features to existing plugins label Jul 24, 2024
@powersj
Copy link
Contributor

powersj commented Jul 24, 2024

Hi,

The expectation was a regular expression match support

Not opposed to introducing this, however:

i.e., starts and ends with a / a regular expression match to be performed

Please create a new configuration option that expects regular expressions. Assuming a leading slash is not safe in the event that someone has used a leading slash in a metric name.

@powersj powersj added help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue waiting for response waiting for response from contributor labels Jul 24, 2024
@dhruvthak
Copy link
Contributor Author

Makes sense. Updated proposal:

Add a separate configuration option:

AddCounterMetricsPatterns []string        `toml:"additional_counters_patterns"`

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 25, 2024
@powersj
Copy link
Contributor

powersj commented Jul 25, 2024

Makes sense. Updated proposal:

Add a separate configuration option:

AddCounterMetricsPatterns []string        `toml:"additional_counters_patterns"`

Sounds good! Look forward to seeing a PR!

@dhruvthak dhruvthak mentioned this issue Jul 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue
Projects
None yet
Milestone
No milestone
2 participants
@dhruvthak @powersj