Add github test skeleton (NOT FOR MERGING)#51
Conversation
alamb
changed the title
| (true, StorageAccountClient::new_emulator_default()) | ||
| // Allow overriding defaults. Values taken from | ||
| // from https://docs.rs/azure_storage/0.2.0/src/azure_storage/core/clients/storage_account_client.rs.html#129-141 | ||
| let http_client = azure_core::new_http_client(); |
There was a problem hiding this comment.
This is needed because when run inside a github runner, other container run as 'services' not on the 127.0.0.1 loopback
|
The 'gcs' tests are failing currently because the fake-gcs container is using https and the tests want to use http. It seems like passing arguments to the docker service containers is challenging for some reason on github. Will sort it out shortly |
| .trim_end_matches('/') | ||
| .to_string(); | ||
|
|
||
| println!("AAL using remote blob base URL: {}", blob_base_url); |
There was a problem hiding this comment.
left over -- should remove before merge
| println!("AAL using remote blob base URL: {}", blob_base_url); |
| fn get_client() -> Result<Client> { | ||
| let mut builder = Client::builder(); | ||
|
|
||
| if std::env::var("GCP_ACCEPT_INVALID_CERTIFICATES").is_ok() { |
There was a problem hiding this comment.
This (or something like it is needed) as I couldn't figure out a way to pass -service http to the fake-gcs-container (apparently this is not supported by github service containers). So I went with this approach instead of allowing invalid certificates via environment -- I may look at the code and see if there is a way to put this into the actual config object and read the environment from the tests.
There was a problem hiding this comment.
You might be able to use https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservicesservice_idoptions to override --entrypoint
There was a problem hiding this comment.
Thank you for the pointer. I tried to override entrypoint -- apparently you can't use it to override the entrypoint and pass along arguments to the binary "for reasons" and the workaround is to make a new docker container in the github action job that has the right arguments. That sounded unnecessarily complicated and so I fell back to this one
alamb
force-pushed
the
alamb/test_gh_actions
branch
from
5b1314a to
25f4896
Compare
|
Will merge in apache/arrow-rs#2148 so closing this PR |
2 participants
This PR is to test porting tests (the integration tests specifically) from circle ci to github actions
The idea is to get the github actions based tests working here and then add them to apache/arrow-rs#2081
Once apache/arrow-rs#2081 is merged, I will then update the tests there as well