Skip to content

fix: InfluxDBClient.close also dispose a created writeApi#79

Merged
bednar merged 1 commit intomasterfrom
fix-close-child-clients
Jan 24, 2020
Merged

fix: InfluxDBClient.close also dispose a created writeApi#79
bednar merged 1 commit intomasterfrom
fix-close-child-clients

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Jan 23, 2020

Closes #78
Closes #33

Calling InfluxDBClient.close should also close a created writeApi:

InfluxDBClient influxDBClient = InfluxDBClientFactory.create(influxdbConfig.getAddress(), influxdbConfig.getToken().toCharArray());

WriteApi writeApi = influxDBClient.getWriteApi();
writeApi.writeRecord("b1", "org1", WritePrecision.NS,"h2o_feet water_level=1.0 1")

# unnecessary
writeApi.close();

influxDBClient.close();
  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added the enhancement New feature or request label Jan 23, 2020
@bednar bednar added this to the 1.5.0 milestone Jan 23, 2020
@bednar bednar requested a review from rhajek January 23, 2020 11:58
@bednar bednar self-assigned this Jan 23, 2020
@bednar bednar merged commit da4e8ff into master Jan 24, 2020
@bednar bednar deleted the fix-close-child-clients branch January 24, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhajek rhajek Awaiting requested review from rhajek

Assignees

@bednar bednar

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

InfluxDBClient should dispose the child clients

1 participant

@bednar