feat: updates service accept header to application/json#733
Merged
karel-rehor merged 16 commits intomasterfrom Jul 19, 2024
Merged
feat: updates service accept header to application/json#733karel-rehor merged 16 commits intomasterfrom
karel-rehor merged 16 commits intomasterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
============================================
+ Coverage 88.37% 88.51% +0.14%
+ Complexity 786 784 -2
============================================
Files 174 174
Lines 7091 7195 +104
Branches 391 405 +14
============================================
+ Hits 6267 6369 +102
+ Misses 698 696 -2
- Partials 126 130 +4 ☔ View full report in Codecov by Sentry. |
bednar
requested changes
Jul 1, 2024
client/src/test/java/com/influxdb/client/ITInfluxQLQueryApi.java
Outdated
Show resolved
Hide resolved
…lsback query method to previous signature.
bednar
requested changes
Jul 16, 2024
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thank you for your PR! 👍 Before we can proceed with accepting it, there are a few requirements that need to be met:
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Show resolved
Hide resolved
bednar
approved these changes
Jul 17, 2024
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thanks again for your PR 👍
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #719
Closes #744
Proposed Changes
Acceptheader inInfluxQLQueryServicetoapplication/jsonChecklist
mvn testcompletes successfully