Conversation
bednar
requested changes
Nov 27, 2023
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thank you for your PR! 👍 Could you please update the CHANGELOG.md file to reflect your changes?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=========================================
Coverage 88.36% 88.36%
Complexity 779 779
=========================================
Files 172 172
Lines 7022 7024 +2
Branches 382 383 +1
=========================================
+ Hits 6205 6207 +2
Misses 698 698
Partials 119 119 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #644
Proposed Changes
When FluxCSVParser parses a value, and the stringValue is empty and the default value for the column is empty, now checks whether the data type for the column is "string" and if this is the case returns the empty default value instead of null.
Note that headerless csv tables will still return null and that null will be returned if the default value is null.
Two tests are added to FluxCsvParserTest.
Checklist
mvn testcompletes successfully