Skip to content

feat(authorization): add possibility to use *Request object in wrapped API#457

Merged
bednar merged 2 commits intomasterfrom
authorization_allow_to_use_request_objects
Oct 25, 2022
Merged

feat(authorization): add possibility to use *Request object in wrapped API#457
bednar merged 2 commits intomasterfrom
authorization_allow_to_use_request_objects

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Oct 25, 2022 •
edited
Loading

Closes #453

Proposed Changes

This PR add possibility to use AuthorizationPostRequest and AuthorizationUpdateRequest in wrapped API - AuthorizationApi.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 25, 2022 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (9ce5275) to head (fd050c1).
⚠️ Report is 326 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #457   +/-   ##
=========================================
  Coverage     88.40%   88.40%           
- Complexity      776      777    +1     
=========================================
  Files           172      172           
  Lines          7010     7014    +4     
  Branches        378      378           
=========================================
+ Hits           6197     6201    +4     
  Misses          693      693           
  Partials        120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar bednar marked this pull request as ready for review October 25, 2022 08:02
@bednar bednar requested a review from vlastahajek October 25, 2022 08:21
vlastahajek
vlastahajek approved these changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bednar bednar merged commit f137cd9 into master Oct 25, 2022
@bednar bednar deleted the authorization_allow_to_use_request_objects branch October 25, 2022 10:29
@bednar bednar added this to the 6.7.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

Missing setter method Authorization.setUserID(String)?

3 participants

@bednar @codecov-commenter @vlastahajek