feat: add FluxRecord.getRow() with response data stored in List#439
Merged
feat: add FluxRecord.getRow() with response data stored in List#439
Conversation
bednar
requested changes
Oct 6, 2022
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
============================================
+ Coverage 88.38% 88.40% +0.01%
Complexity 776 776
============================================
Files 172 172
Lines 6999 7010 +11
Branches 377 378 +1
============================================
+ Hits 6186 6197 +11
Misses 693 693
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bednar
requested changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding possibility of accessing response data in List FluxRecord.getRow().
In case of using pivot on data, where field contains labels that occur by default in the annotated CSV (f.e. "result" or "table"), could be duplicated column names in response. In that case FluxRecord.getValues() (Map), which can hold only unique keys, doesn't show complete data. This edge case is solved by using FluxRecord.getRow() (List).
Checklist
mvn testcompletes successfully