feat: extend flux-dsl#373
Merged
bednar merged 4 commits intoinfluxdata:masterfrom Jul 8, 2022
Merged
Conversation
* Add ability to define imports for each flux function * Add ability use multiple flux expressions * Add ability to define custom functions * Improve join flux, so it can be nested * Add missing parameter variants for RangeFlux amd AggregateWindow * Add TruncateTimeColumnFlux
Andy2003
force-pushed
the
feature/extend-flux-dsl
branch
from
8b4a6df to
72f0fd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
============================================
+ Coverage 89.02% 89.60% +0.58%
- Complexity 636 721 +85
============================================
Files 156 166 +10
Lines 6358 6573 +215
Branches 305 326 +21
============================================
+ Hits 5660 5890 +230
+ Misses 612 591 -21
- Partials 86 92 +6
Continue to review full report at Codecov.
|
bednar
requested changes
Jul 5, 2022
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Hi @Andy2003, thanks for your PR 👍
Can you satisfy following requirements:
- Add new functions into
flux-dsl/README.md:InterpolateLinearFluxTruncateTimeColumnFlux
- Add description how to use the
importsintoflux-dsl/README.md - Add description how to use the
AbstractFunctionFluxintoflux-dsl/README.md
and also:
* Add ability to define imports for each flux function [FluxDSL] * Add ability use multiple flux expressions [FluxDSL] * Add ability to define custom functions [FluxDSL] * Improve join flux, so it can be nested [FluxDSL] * Add missing parameter variants for RangeFlux amd AggregateWindow [FluxDSL] * Add TruncateTimeColumnFlux [FluxDSL] * Add ArrayFromFlux [FluxDSL] * Add UnionFlux [FluxDSL]
bednar
requested changes
Jul 6, 2022
bednar
approved these changes
Jul 8, 2022
Contributor
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
LGMT 🚀
Thanks again for your PR 👍. From my POV is ready to merge into master. Do you want to continue in work or it is done?
Contributor
Author
No it's all done, please merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
mvn testcompletes successfully