Skip to content

feat: add possibility to customize the User-Agent HTTP header#371

Merged
bednar merged 2 commits intomasterfrom
custom-user-agent
Jun 30, 2022
Merged

feat: add possibility to customize the User-Agent HTTP header#371
bednar merged 2 commits intomasterfrom
custom-user-agent

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Jun 29, 2022

Closes #370

Proposed Changes

Added possibility to customise the User-Agent HTTP header:

InfluxDBClientOptions options = InfluxDBClientOptions
                .builder()
                .url("http://localhost:8086")
                .clientType("awesome-service")
                .authenticateToken("my-token".toCharArray())
                .build();

=>

User-Agent: influxdb-client-awesome-service/6.3.0

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek June 29, 2022 12:43
@bednar bednar marked this pull request as ready for review June 29, 2022 12:43
Copy link
Copy Markdown
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need also to add clientType settings to our nifi processor

@bednar bednar merged commit bf2f4f9 into master Jun 30, 2022
@bednar bednar deleted the custom-user-agent branch June 30, 2022 05:23
@bednar bednar added this to the 6.3.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to customize User-Agent header

2 participants