Skip to content

feat: expose /query endpoint to use InfluxQL (#365)#366

Merged
bednar merged 3 commits intoinfluxdata:masterfrom
Andy2003:feature/gh-356-influxql-endpoint
Aug 2, 2022
Merged

feat: expose /query endpoint to use InfluxQL (#365)#366
bednar merged 3 commits intoinfluxdata:masterfrom
Andy2003:feature/gh-356-influxql-endpoint

Conversation

@Andy2003
Copy link
Copy Markdown
Contributor

@Andy2003 Andy2003 commented Jun 23, 2022

Closes #365

Proposed Changes

Added an endpoint to query against the InfluxQL endpoint (v1)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 8483830 to 140d9d4 Compare June 23, 2022 13:15
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 23, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 58.08824% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.31%. Comparing base (32ac909) to head (a811a1a).
⚠️ Report is 388 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/com/influxdb/query/InfluxQLQueryResult.java 0.00% 34 Missing ⚠️
...influxdb/client/internal/InfluxQLQueryApiImpl.java 82.08% 9 Missing and 3 partials ⚠️
...java/com/influxdb/client/domain/InfluxQLQuery.java 65.62% 11 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     88.91%   88.31%   -0.61%     
  Complexity      778      778              
============================================
  Files           169      172       +3     
  Lines          6864     6998     +134     
  Branches        364      375      +11     
============================================
+ Hits           6103     6180      +77     
- Misses          653      707      +54     
- Partials        108      111       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy2003 thanks for your fantastic PR 👍

Is it ready for review?

@Andy2003
Copy link
Copy Markdown
Contributor Author

Is it ready for review?

Yes it is

@Andy2003 Andy2003 requested a review from bednar July 5, 2022 07:36
@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from c09c19c to 5facd17 Compare July 5, 2022 09:30
@Andy2003
Copy link
Copy Markdown
Contributor Author

@bednar Is there anything I can do to get this merged?

@bednar
Copy link
Copy Markdown
Contributor

bednar commented Jul 13, 2022

Hi @Andy2003,

sorry for the late.

We currently discuss how to line up the support of other languages in the our client libraries. I hope so that we will be able to do a review soon and then merge it into master.

Regards

@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 5facd17 to 7cb475f Compare July 15, 2022 06:43
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍 and sorry for the late.

There are few requirements which has to be satisfied before we will merge this PR into master:

  • Please add an example how to use the InfluxQL into examples/src/main/java/example, examples/README.md

and also satisfy following requirements:

Comment thread CHANGELOG.md Outdated
Comment thread README.md
Comment thread client-core/src/main/java/com/influxdb/internal/AbstractQueryApi.java Outdated
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java Outdated
Comment thread client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java Outdated
Comment thread client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java Outdated
Comment thread client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java Outdated
@Andy2003 Andy2003 requested a review from bednar July 29, 2022 08:32
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Outdated
Comment thread client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Outdated
Comment thread examples/src/main/java/example/InfluxQLExample.java
@Andy2003 Andy2003 requested a review from bednar August 1, 2022 12:42
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy2003 thanks again for your PR 👍 We are almost done..

Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java Outdated
Comment thread client/README.md Outdated
Comment thread client/src/test/java/com/influxdb/client/ITInfluxQLQueryService.java Outdated
Comment thread client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Outdated
Comment thread client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Outdated
Comment thread client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java Outdated
@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 6c387ec to 58c64e0 Compare August 2, 2022 07:31
@Andy2003 Andy2003 requested a review from bednar August 2, 2022 07:32
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Andy2003 thanks you very much for this PR

@bednar bednar added this to the 6.5.0 milestone Aug 2, 2022
@bednar bednar merged commit 382c2f3 into influxdata:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose /query endpoint to use influxQL

3 participants