fix: enable OkHttp retries for connection failure#359
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
============================================
- Coverage 88.99% 88.98% -0.01%
Complexity 634 634
============================================
Files 155 155
Lines 6340 6339 -1
Branches 302 302
============================================
- Hits 5642 5641 -1
Misses 612 612
Partials 86 86
Continue to review full report at Codecov.
|
rhajek
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR enables OkHttp retries strategy for connection failures.
We don't need to disable the
retryOnConnectionFailure. The retry logic in the OkHttp is not in a collision with ourexponential backoff strategyfor writes. OkHttp logic uses the possibility of routing to another "routes" - e.g. network loopback or multiple proxies.For more info see:
Checklist
mvn testcompletes successfully