Skip to content

fix: creating Tasks with import statements#352

Merged
rhajek merged 2 commits intomasterfrom
fix_create_task_with_import
May 18, 2022
Merged

fix: creating Tasks with import statements#352
rhajek merged 2 commits intomasterfrom
fix_create_task_with_import

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented May 18, 2022 •
edited
Loading

Closes #351

Proposed Changes

Fixed creating Task with import statement:

String flux = "import \"experimental\"\n"
        + "\n"
        + "from(bucket: \"my-bucket\")\n"
        + "    |> range(start: experimental.addDuration(d: -1d, to: today()), stop: today())\n"
        + "    |> max()";

Task task = tasksApi.createTaskCron("my-task", flux, "10 0 * * * *", organization.getId());

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review May 18, 2022 06:55
@bednar bednar requested a review from rhajek May 18, 2022 06:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2022 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.89%. Comparing base (19cf00f) to head (f9942e1).
⚠️ Report is 433 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage     88.88%   88.89%           
  Complexity      633      633           
=========================================
  Files           153      153           
  Lines          6282     6285    +3     
  Branches        302      302           
=========================================
+ Hits           5584     5587    +3     
  Misses          612      612           
  Partials         86       86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhajek rhajek merged commit 06ac268 into master May 18, 2022
@rhajek rhajek deleted the fix_create_task_with_import branch May 18, 2022 12:30
@bednar bednar added this to the 6.1.0 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1.0

Development

Successfully merging this pull request may close these issues.

creating/updating task with leading import statement not working

3 participants

@bednar @codecov-commenter @rhajek