Skip to content

fix: evaluation of connection string#339

Merged
bednar merged 2 commits intomasterfrom
fix_default_org_bucket
Apr 28, 2022
Merged

fix: evaluation of connection string#339
bednar merged 2 commits intomasterfrom
fix_default_org_bucket

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Apr 20, 2022 •
edited
Loading

Related to #335, #338 (comment)

Proposed Changes

Fix: If the bucket or the org is defined before url then the defaults for bucket and org is replaced with null.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 20, 2022 11:36
@bednar bednar requested a review from rhajek April 20, 2022 11:37
@bednar bednar added the bug Something isn't working label Apr 20, 2022
@bednar bednar merged commit 124c691 into master Apr 28, 2022
@bednar bednar deleted the fix_default_org_bucket branch April 28, 2022 08:01
@bednar bednar added this to the 6.1.0 milestone Apr 28, 2022
@bednar bednar mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

6.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bednar @rhajek