Skip to content

feat(flux_dsl): add support for timezones#315

Merged
bednar merged 3 commits intomasterfrom
flux_dsl_timezone
Mar 22, 2022
Merged

feat(flux_dsl): add support for timezones#315
bednar merged 3 commits intomasterfrom
flux_dsl_timezone

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Mar 17, 2022 •
edited
Loading

Closes #309

Proposed Changes

Add support for timezones:

Flux flux = Flux
    .from("telegraf")
    .withLocationFixed("-8h")
    .count();

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review March 17, 2022 08:17
@bednar bednar requested a review from rhajek March 17, 2022 08:17
@bednar bednar force-pushed the flux_dsl_timezone branch from 2d8034f to 2fbdab3 Compare March 18, 2022 06:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 18, 2022 •
edited
Loading

Codecov Report

Merging #315 (2fbdab3) into master (8f2c513) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #315      +/-   ##
============================================
+ Coverage     88.97%   89.00%   +0.02%     
- Complexity      473      480       +7     
============================================
  Files           149      149              
  Lines          6005     6030      +25     
  Branches        290      290              
============================================
+ Hits           5343     5367      +24     
  Misses          580      580              
- Partials         82       83       +1
Impacted Files Coverage Δ
...ava/com/influxdb/query/dsl/functions/JoinFlux.java 0.00% <ø> (ø)
...dsl/src/main/java/com/influxdb/query/dsl/Flux.java 96.12% <100.00%> (ø)
...ava/com/influxdb/query/dsl/functions/FromFlux.java 100.00% <100.00%> (ø)
.../query/dsl/functions/AbstractFluxWithUpstream.java 92.30% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2c513...2fbdab3. Read the comment docs.

@bednar bednar force-pushed the flux_dsl_timezone branch from 2fbdab3 to 38eaa7a Compare March 22, 2022 09:31
@bednar bednar merged commit 123fa8a into master Mar 22, 2022
@bednar bednar deleted the flux_dsl_timezone branch March 22, 2022 09:48
@bednar bednar added this to the 5.1.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

how to use truncateTimeColumn or date.truncate?

3 participants

@bednar @codecov-commenter @rhajek