Skip to content

test: add client performance/benchmark test#312

Merged
rhajek merged 9 commits intomasterfrom
client_benchmark
Mar 22, 2022
Merged

test: add client performance/benchmark test#312
rhajek merged 9 commits intomasterfrom
client_benchmark

Conversation

@rhajek
Copy link
Copy Markdown
Contributor

@rhajek rhajek commented Mar 11, 2022

Proposed Changes

This PR adds client benchmarking test that validates the client writes in multithreaded load.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@rhajek rhajek requested a review from bednar March 11, 2022 16:01
@rhajek rhajek changed the title test: Add client performance/benchmark test test: add client performance/benchmark test Mar 11, 2022
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

There are a few requirements that must be be satisfy before we accept the PR:

Comment thread .circleci/config.yml Outdated
Comment thread client/src/test/java/com/influxdb/client/ITBenchmarkTest.java Outdated
Comment thread client/src/test/java/com/influxdb/client/ITBenchmarkTest.java Outdated
Comment thread pom.xml Outdated
<dependency.gson.version>2.8.8</dependency.gson.version>

<plugin.surefire.version>2.22.2</plugin.surefire.version>
<plugin.surefire.version>3.0.0-M3</plugin.surefire.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use latest milestone version:

Suggested change
<plugin.surefire.version>3.0.0-M3</plugin.surefire.version>
<plugin.surefire.version>3.0.0-M5</plugin.surefire.version>

@rhajek rhajek requested a review from bednar March 22, 2022 09:24
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rhajek rhajek merged commit aa30362 into master Mar 22, 2022
@rhajek rhajek deleted the client_benchmark branch March 22, 2022 13:01
@bednar bednar added this to the 5.1.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants