Skip to content

fix: change type of PermissionResource.type to String to avoid exception for non-existing item#303

Merged
bednar merged 4 commits intomasterfrom
permission_resource_type_as_string
Feb 22, 2022
Merged

fix: change type of PermissionResource.type to String to avoid exception for non-existing item#303
bednar merged 4 commits intomasterfrom
permission_resource_type_as_string

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Feb 21, 2022

Proposed Changes

The PermissionResource.type is not constant value and can evolve as the API of InfluxDB changing.

=>

Change type of PermissionResource.type to String.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review February 21, 2022 10:23
@bednar bednar requested a review from rhajek February 21, 2022 10:23
Copy link
Copy Markdown
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 0306299 into master Feb 22, 2022
@bednar bednar deleted the permission_resource_type_as_string branch February 22, 2022 14:36
@bednar bednar added this to the 4.4.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants