Skip to content

fix: default dialect (#284)#285

Merged
bednar merged 5 commits intomasterfrom
fix/default_dialect
Dec 6, 2021
Merged

fix: default dialect (#284)#285
bednar merged 5 commits intomasterfrom
fix/default_dialect

Conversation

@rhajek
Copy link
Copy Markdown
Contributor

@rhajek rhajek commented Dec 1, 2021 •
edited by bednar
Loading

Closes #284

This PR fixes usage of default dialect in QueryAPI.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #285 (8abd56c) into master (17fb8fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8abd56c differs from pull request most recent head 13b5718. Consider uploading reports for the commit 13b5718 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #285   +/-   ##
=========================================
  Coverage     89.71%   89.71%           
  Complexity      473      473           
=========================================
  Files           149      149           
  Lines          5912     5913    +1     
  Branches        283      283           
=========================================
+ Hits           5304     5305    +1     
  Misses          524      524           
  Partials         84       84
Impacted Files Coverage Δ
...luxdb/client/kotlin/internal/QueryKotlinApiImpl.kt 94.02% <100.00%> (ø)
...uxdb/client/scala/internal/QueryScalaApiImpl.scala 100.00% <100.00%> (ø)
...ava/com/influxdb/client/internal/QueryApiImpl.java 98.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fb8fa...13b5718. Read the comment docs.

@rhajek rhajek requested a review from bednar December 1, 2021 15:33
bednar
bednar requested changes Dec 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR 👍

Please also update following implementations:

  • QueryKotlinApiImpl
  • QueryScalaApiImpl

@rhajek rhajek requested a review from bednar December 3, 2021 16:12
@bednar bednar added the bug Something isn't working label Dec 6, 2021
@bednar bednar merged commit 29a0205 into master Dec 6, 2021
@bednar bednar deleted the fix/default_dialect branch December 6, 2021 07:38
@bednar bednar added this to the 4.1.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

Cloud2 query throws FluxCsvParserException

3 participants

@rhajek @codecov-commenter @bednar