Skip to content

fix: serialization null tag's value into LineProtocol#283

Merged
bednar merged 2 commits intomasterfrom
fix/tag-null
Nov 30, 2021
Merged

fix: serialization null tag's value into LineProtocol#283
bednar merged 2 commits intomasterfrom
fix/tag-null

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Nov 30, 2021 •
edited
Loading

Closes #282

Proposed Changes

Fixed serialization a Point into LineProtocol when tag's value is null.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 30, 2021 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (f2ef610) to head (05e18b2).
⚠️ Report is 467 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #283   +/-   ##
=========================================
  Coverage     89.71%   89.71%           
  Complexity      473      473           
=========================================
  Files           149      149           
  Lines          5912     5912           
  Branches        283      283           
=========================================
  Hits           5304     5304           
  Misses          524      524           
  Partials         84       84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar bednar marked this pull request as ready for review November 30, 2021 07:34
@bednar bednar requested a review from rhajek November 30, 2021 07:42
@bednar bednar mentioned this pull request Nov 30, 2021
Closed
@bednar bednar merged commit 17fb8fa into master Nov 30, 2021
@bednar bednar deleted the fix/tag-null branch November 30, 2021 13:07
@bednar bednar added this to the 4.1.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

Client failing to save when Tag value is null

3 participants

@bednar @codecov-commenter @rhajek