feat: add query method with all params for BucketsApi, OrganizationApi and TasksApi by lonelyleaf · Pull Request #278 · influxdata/influxdb-client-java

lonelyleaf · 2021-11-04T09:55:33Z

Closes #277

Proposed Changes

add query with full rest params for buckets,org and tasks api.

Checklist

bednar

Thanks again for your PR 👍.

Please, satisfy the PR checklist:

and there are also code style requirements:

lonelyleaf · 2021-11-04T13:22:26Z

@bednar I will satisfy the PR checklist tomorrow or next week

bednar · 2021-11-04T13:25:11Z

Thanks, you can easily satisfy request by:

Co-authored-by: Jakub Bednář <[email protected]>

…pl.java Co-authored-by: Jakub Bednář <[email protected]>

…sApiImpl.java Co-authored-by: Jakub Bednář <[email protected]>

….java Co-authored-by: Jakub Bednář <[email protected]>

Co-authored-by: Jakub Bednář <[email protected]>

lonelyleaf · 2021-11-04T14:24:51Z

@bednar Is there anything else that need me to be done?I haven't run mvn test and should I open anyother PR and rebase those commit？(´･_･`)

bednar

You don't have to create a new rebased PR, I will squash the commits before merge the PR into master.

There are only a few requirements before merge the PR into master:

Update CHANGELOG.md
Satisfy following requirements:

Co-authored-by: Jakub Bednář <[email protected]>

…pl.java Co-authored-by: Jakub Bednář <[email protected]>

Co-authored-by: Jakub Bednář <[email protected]>

lonelyleaf · 2021-11-05T07:58:08Z

@bednar CHANGELOG.md updated

bednar · 2021-11-05T08:02:17Z

Please, fix a compilation error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project influxdb-client-java: Compilation failure: Compilation failure: 
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/TaskQuery.java:[26,8] class TasksQuery is public, should be declared in a file named TasksQuery.java
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/TasksApi.java:[276,41] cannot access com.influxdb.client.TaskQuery
[ERROR]   bad source file: /home/circleci/project/client/src/main/java/com/influxdb/client/TaskQuery.java
[ERROR]     file does not contain class com.influxdb.client.TaskQuery
[ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[140,48] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[130,15] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[130,41] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] -> [Help 1]

https://app.circleci.com/pipelines/github/influxdata/influxdb-client-java/1381/workflows/abd10798-16a9-47d3-8528-4b564ec87ff7/jobs/4247

You have to rename TaskQuery to TasksQuery at all places.

bednar · 2021-11-05T08:03:19Z

The CI builds has to be green ;)

codecov-commenter · 2021-11-05T08:34:48Z

Codecov Report

Merging #278 (b277596) into master (59b0d63) will decrease coverage by 0.65%.
The diff coverage is 39.74%.

@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     89.05%   88.39%   -0.66%     
  Complexity      473      473              
============================================
  Files           145      148       +3     
  Lines          5791     5867      +76     
  Branches        275      275              
============================================
+ Hits           5157     5186      +29     
- Misses          554      601      +47     
  Partials         80       80

Impacted Files	Coverage Δ
...rc/main/java/com/influxdb/client/BucketsQuery.java	`0.00% <0.00%> (ø)`
...a/com/influxdb/client/internal/BucketsApiImpl.java	`70.55% <0.00%> (-2.24%)`	⬇️
...n/java/com/influxdb/client/OrganizationsQuery.java	`36.84% <36.84%> (ø)`
.../src/main/java/com/influxdb/client/TasksQuery.java	`63.63% <63.63%> (ø)`
...influxdb/client/internal/OrganizationsApiImpl.java	`93.02% <100.00%> (+0.10%)`	⬆️
...ava/com/influxdb/client/internal/TasksApiImpl.java	`84.32% <100.00%> (+0.40%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b0d63...b277596. Read the comment docs.

lonelyleaf · 2021-11-05T08:38:46Z

@bednar fixed for ci

bednar

Thanks again for PR

LGTM 💯

add query with full rest params for buckets,org and tasks api.

30ba009

lonelyleaf mentioned this pull request Nov 4, 2021

add query by name for buckets，tasks and orgs api #277

Closed

bednar requested changes Nov 4, 2021

View reviewed changes

lonelyleaf and others added 25 commits November 4, 2021 21:27

Update client/src/main/java/com/influxdb/client/BucketsApi.java

7fbabae

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

3d1e24c

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

3d7b52d

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

6434fb1

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

d74d02c

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/BucketsApiIm…

61439fc

…pl.java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/Organization…

8948163

…sApiImpl.java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/TasksApiImpl…

e50bd11

….java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/TasksApiImpl…

2e05888

….java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/TasksApiImpl…

0952a9a

….java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

26f5afd

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

f60965c

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

9f39d5b

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsApi.java

fae5156

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

ab01f01

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

aad6b1e

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

b88bc94

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

0d7d221

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

6ffaef8

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

b61fe8b

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

1640ad6

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

1633270

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

35252af

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

5c20a7c

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

12110d4

Co-authored-by: Jakub Bednář <[email protected]>

bednar requested changes Nov 5, 2021

View reviewed changes

bednar changed the title ~~add query with full rest params for buckets,org and tasks api.~~ feat: add query method with all params for BucketsApi, OrganizationApi and TasksApi Nov 5, 2021

lonelyleaf and others added 15 commits November 5, 2021 15:41

Update client/src/main/java/com/influxdb/client/TaskQuery.java

82b3509

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

679a669

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/internal/BucketsApiIm…

89c8426

…pl.java Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

0fd8f13

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

0589e7c

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

d984e43

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

d490997

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

ecf0fc9

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

0ae6fe8

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

01cfdae

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

7439e25

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/OrganizationsQuery.java

f35c777

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/TaskQuery.java

a1f6294

Co-authored-by: Jakub Bednář <[email protected]>

Update client/src/main/java/com/influxdb/client/BucketsQuery.java

dbbe70c

Co-authored-by: Jakub Bednář <[email protected]>

update CHANGELOG.md

90b060b

luoqiyi added 2 commits November 5, 2021 16:14

fix compilation error

4a15418

fix for checkstyle

b277596

bednar approved these changes Nov 5, 2021

View reviewed changes

bednar merged commit 7e4b969 into influxdata:master Nov 5, 2021

bednar added this to the 3.5.0 milestone Nov 5, 2021

bednar added the enhancement New feature or request label Nov 5, 2021

bednar mentioned this pull request Nov 8, 2021

fix(java): patch is compatible with upcoming filters by all params influxdata/influxdb-clients-apigen#33

Merged

3 tasks

Conversation

lonelyleaf commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Checklist

Uh oh!

bednar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lonelyleaf commented Nov 4, 2021

Uh oh!

bednar commented Nov 4, 2021

Uh oh!

lonelyleaf commented Nov 4, 2021

Uh oh!

bednar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lonelyleaf commented Nov 5, 2021

Uh oh!

bednar commented Nov 5, 2021

Uh oh!

bednar commented Nov 5, 2021

Uh oh!

codecov-commenter commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lonelyleaf commented Nov 5, 2021

Uh oh!

bednar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lonelyleaf commented Nov 4, 2021 •

edited

Loading

codecov-commenter commented Nov 5, 2021 •

edited

Loading