Skip to content

feat: add PingService to check status of OSS and Cloud instance#272

Merged
bednar merged 2 commits intomasterfrom
feat/ping
Oct 22, 2021
Merged

feat: add PingService to check status of OSS and Cloud instance#272
bednar merged 2 commits intomasterfrom
feat/ping

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Oct 21, 2021 •
edited
Loading

Proposed Changes

  1. Added PingService to check status of OSS and Cloud instance.
  2. Deprecates:
    • InfluxDBClient.health()
    • InfluxDBClientKotlin.health()
    • InfluxDBClientScala.health()

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar mentioned this pull request Oct 21, 2021
Merged
3 tasks
@bednar bednar marked this pull request as ready for review October 21, 2021 08:08
@bednar bednar requested a review from rhajek October 21, 2021 08:08
@bednar bednar added this to the 3.5.0 milestone Oct 22, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #272 (c1204c4) into master (90471b8) will decrease coverage by 0.08%.
The diff coverage is 37.50%.

❗ Current head c1204c4 differs from pull request most recent head 8465ebc. Consider uploading reports for the commit 8465ebc to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
- Coverage     89.13%   89.05%   -0.09%     
  Complexity      473      473              
============================================
  Files           145      145              
  Lines          5790     5791       +1     
  Branches        276      275       -1     
============================================
- Hits           5161     5157       -4     
- Misses          549      554       +5     
  Partials         80       80
Impacted Files Coverage Δ
...java/com/influxdb/internal/AbstractRestClient.java 80.00% <0.00%> (-20.00%) ⬇️
...fluxdb/spring/health/InfluxDB2HealthIndicator.java 44.44% <0.00%> (+17.77%) ⬆️
...client/kotlin/internal/InfluxDBClientKotlinImpl.kt 100.00% <100.00%> (ø)
...com/influxdb/client/flux/internal/FluxApiImpl.java 100.00% <100.00%> (ø)
...lient/scala/internal/InfluxDBClientScalaImpl.scala 100.00% <100.00%> (ø)
...fluxdb/client/internal/AbstractInfluxDBClient.java 92.59% <100.00%> (+0.13%) ⬆️
...m/influxdb/client/internal/InfluxDBClientImpl.java 87.71% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ac3b3...8465ebc. Read the comment docs.

@bednar bednar merged commit e3418dd into master Oct 22, 2021
@bednar bednar deleted the feat/ping branch October 22, 2021 09:00
@bednar bednar mentioned this pull request Oct 26, 2021
Closed
@PLeusmann PLeusmann mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bednar @codecov-commenter @rhajek