fix: read entire query response into bytes array#254
Merged
Conversation
Merged
3 tasks
bednar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=========================================
Coverage 89.26% 89.26%
Complexity 449 449
=========================================
Files 145 145
Lines 5767 5767
Branches 271 271
=========================================
Hits 5148 5148
Misses 540 540
Partials 79 79 Continue to review full report at Codecov.
|
rhajek
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Proposed Changes
Avoid to read entire query response into byte arrays - https://square.github.io/retrofit/2.x/retrofit/retrofit2/http/Streaming.html
Checklist
mvn testcompletes successfully