Skip to content

fix: parsing infinite numbers#246

Merged
bednar merged 4 commits intomasterfrom
fix/parsing-inf
Jul 22, 2021
Merged

fix: parsing infinite numbers#246
bednar merged 4 commits intomasterfrom
fix/parsing-inf

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Jul 14, 2021 •
edited
Loading

Closes #239

Proposed Changes

Fixed parsing Inf+ for histogram() function.

Response example

#group,false,false,true,true,true,true,true,true,true,true,false,false
#datatype,string,long,dateTime:RFC3339,dateTime:RFC3339,string,string,string,string,string,string,double,double
#default,_result,,,,,,,,,,,
,result,table,_start,_stop,_field,_measurement,language,license,name,owner,le,_value
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,0,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,10,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,20,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,30,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,40,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,50,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,60,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,70,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,80,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,90,0
,,0,2021-06-23T06:50:11.897825012Z,2021-06-25T06:50:11.897825012Z,stars,github_repository,C#,MIT License,influxdb-client-csharp,influxdata,+Inf,15

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #246 (95b7bf3) into master (4cbe996) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #246   +/-   ##
=========================================
  Coverage     89.14%   89.14%           
  Complexity      442      442           
=========================================
  Files           143      143           
  Lines          5756     5759    +3     
  Branches        270      271    +1     
=========================================
+ Hits           5131     5134    +3     
  Misses          546      546           
  Partials         79       79
Impacted Files Coverage Δ
...ava/com/influxdb/query/internal/FluxCsvParser.java 97.29% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbe996...95b7bf3. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 14, 2021 05:54
@bednar bednar requested a review from rhajek July 14, 2021 05:54
@bednar bednar changed the title fix: parsing Infinite numbers into Double fix: parsing infinite numbers Jul 14, 2021
@bednar bednar force-pushed the fix/parsing-inf branch from 777725b to 95b7bf3 Compare July 22, 2021 12:35
@bednar bednar merged commit 643d3da into master Jul 22, 2021
@bednar bednar deleted the fix/parsing-inf branch July 22, 2021 15:29
@bednar bednar added this to the 3.1.0 milestone Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

Get NumberFormatException for +Inf when I query a 'Histogram'

3 participants

@bednar @codecov-commenter @rhajek