Skip to content

feat: use InfluxDB OSS API definitions to generated APIs#233

Merged
bednar merged 4 commits intomasterfrom
feat/api-from-openapi-repository
Jul 7, 2021
Merged

feat: use InfluxDB OSS API definitions to generated APIs#233
bednar merged 4 commits intomasterfrom
feat/api-from-openapi-repository

Conversation

@bednar
Copy link
Copy Markdown
Contributor

@bednar bednar commented Jun 17, 2021 •
edited
Loading

Proposed Changes

  • Use InfluxDB OSS API definitions to generated APIs.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 17, 2021 10:21
@bednar bednar requested a review from rhajek June 17, 2021 10:21
rhajek
rhajek suggested changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to breaking changes, we should increase the major version of the client.

@bednar
Copy link
Copy Markdown
Contributor Author

bednar commented Jun 21, 2021

The major version was increased to 3.0.0

@bednar bednar requested a review from rhajek June 21, 2021 07:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #233 (6883ae6) into master (e2adb62) will decrease coverage by 0.13%.
The diff coverage is 79.36%.

❗ Current head 6883ae6 differs from pull request most recent head ffc4ead. Consider uploading reports for the commit ffc4ead to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage     89.27%   89.13%   -0.14%     
  Complexity      442      442              
============================================
  Files           143      143              
  Lines          5713     5752      +39     
  Branches        270      270              
============================================
+ Hits           5100     5127      +27     
- Misses          534      546      +12     
  Partials         79       79
Impacted Files Coverage Δ
...a/com/influxdb/client/internal/BucketsApiImpl.java 72.78% <13.33%> (-5.99%) ⬇️
...nfluxdb/client/internal/AuthorizationsApiImpl.java 100.00% <100.00%> (ø)
...va/com/influxdb/client/internal/ChecksApiImpl.java 96.93% <100.00%> (ø)
...om/influxdb/client/internal/DashboardsApiImpl.java 85.33% <100.00%> (+0.29%) ⬆️
...va/com/influxdb/client/internal/DeleteApiImpl.java 100.00% <100.00%> (ø)
...m/influxdb/client/internal/InfluxDBClientImpl.java 97.95% <100.00%> (+0.08%) ⬆️
...influxdb/client/internal/OrganizationsApiImpl.java 92.91% <100.00%> (+0.47%) ⬆️
...ava/com/influxdb/client/internal/TasksApiImpl.java 83.91% <100.00%> (ø)
...ava/com/influxdb/client/internal/UsersApiImpl.java 66.66% <100.00%> (+3.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2adb62...ffc4ead. Read the comment docs.

@bednar bednar merged commit b251542 into master Jul 7, 2021
@bednar bednar deleted the feat/api-from-openapi-repository branch July 7, 2021 05:55
@bednar bednar added this to the 2.4.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rhajek rhajek rhajek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bednar @codecov-commenter @rhajek