Skip to content

feat: support translating column name from some_col to someCol#229

Merged
bednar merged 7 commits intoinfluxdata:masterfrom
uqix:issue-228
Jun 10, 2021
Merged

feat: support translating column name from some_col to someCol#229
bednar merged 7 commits intoinfluxdata:masterfrom
uqix:issue-228

Conversation

@uqix
Copy link
Copy Markdown
Contributor

@uqix uqix commented Jun 2, 2021 •
edited
Loading

Closes #228

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

bednar
bednar requested changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍.

There is a few requirements that should be satisfy before we accept the PR:

Comment thread client-core/pom.xml Outdated
Comment thread client-core/src/main/java/com/influxdb/query/internal/FluxResultMapper.java
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #229 (83c08b8) into master (7e8afdf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
+ Coverage     89.16%   89.25%   +0.08%     
  Complexity      442      442              
============================================
  Files           143      143              
  Lines          5696     5703       +7     
  Branches        269      270       +1     
============================================
+ Hits           5079     5090      +11     
+ Misses          538      534       -4     
  Partials         79       79
Impacted Files Coverage Δ
.../com/influxdb/query/internal/FluxResultMapper.java 65.11% <100.00%> (+8.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8afdf...83c08b8. Read the comment docs.

bednar
bednar requested changes Jun 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍
There is a few requirements that should be satisfy before we accept the PR:

  1. Rollback changes in client-core/pom.xml - there are only whitespaces
  2. Satisfy requirements from PR Checklist:
    Screenshot 2021-06-09 at 12 54 00

@uqix uqix changed the title Support translating column name from some_col to someCol feat: support translating column name from some_col to someCol Jun 10, 2021
bednar
bednar requested changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update README.md following way and we will be ready to merge PR into master:

Comment thread CHANGELOG.md Outdated
@bednar bednar merged commit 419f942 into influxdata:master Jun 10, 2021
@bednar
Copy link
Copy Markdown
Contributor

bednar commented Jun 10, 2021

PR is merged into master. Thanks again 👍

@bednar bednar added this to the 2.4.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

FluxResultMapper - support translating column name from some_col to someCol

3 participants

@uqix @codecov-commenter @bednar